Fix PutIndexTemplateRequest deserialization #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbogner
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: Matthew Bogner <[email protected]>
matthewbogner
force-pushed
the
mbogner-putindextemplaterequest-deser
branch
from
f78b520
to
5a36989
Compare
Signed-off-by: Matthew Bogner <[email protected]>
Signed-off-by: Matthew Bogner <[email protected]>
dblock
approved these changes
Dec 12, 2023
VachaShah
approved these changes
Dec 12, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-765-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d4aade4e866556f8a11ed05756ab8b01f2ed0e71
# Push it to GitHub
git push --set-upstream origin backport/backport-765-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
|
@matthewbogner Looks like this will need a manual backport if you want the fix in a 2.x release. |
matthewbogner
added a commit
to matthewbogner/opensearch-java
that referenced
this pull request
Dec 12, 2023
* Fix PutIndexTemplateRequest deserialization Signed-off-by: Matthew Bogner <[email protected]> * CHANGELOG.md Signed-off-by: Matthew Bogner <[email protected]> * spotless Signed-off-by: Matthew Bogner <[email protected]> --------- Signed-off-by: Matthew Bogner <[email protected]> (cherry picked from commit d4aade4)
VachaShah
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Fix PutIndexTemplateRequest deserialization Signed-off-by: Matthew Bogner <[email protected]> * CHANGELOG.md Signed-off-by: Matthew Bogner <[email protected]> * spotless Signed-off-by: Matthew Bogner <[email protected]> --------- Signed-off-by: Matthew Bogner <[email protected]> (cherry picked from commit d4aade4)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds in the missing deserialization steps to the PutIndexTemplateRequest _DESERIALIZER which would result in the error
Missing required property 'PutIndexTemplateRequest.name' if you tried to deserialize a request object.
Issues Resolved
Relates to issues #417, #618 and PR #723
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.